From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] bcma: signedness bug in bcma_get_next_core()
Date: Sat, 20 Aug 2011 14:11:38 +0000 [thread overview]
Message-ID: <4E4FC09A.3080603@bfs.de> (raw)
In-Reply-To: <20110818133809.GG4786@shale.localdomain>
Am 20.08.2011 15:31, schrieb Rafał Miłecki:
> W dniu 20 sierpnia 2011 14:59 użytkownik walter harms <wharms@bfs.de> napisał:
>>
>>
>> Am 20.08.2011 14:23, schrieb Rafał Miłecki:
>>> W dniu 18 sierpnia 2011 15:38 użytkownik Dan Carpenter
>>> <error27@gmail.com> napisał:
>>>> The u32 would never be less than zero so the error handling would
>>>> break. I changed it to int.
>>>
>>> In declaration we use s32:
>>> static s32 bcma_erom_get_mst_port(struct bcma_bus *bus, u32 **eromptr);
>>>
>>> Doesn't it sound better to use s32 instead of int?
>>>
>>
>> aktualy int sounds better that s32 for me.
>
> Will you care to replace function return type as well?
>
not me, i would have to download a decent kernel etc, just to change
an s32 into int.
re,
wh
next prev parent reply other threads:[~2011-08-20 14:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 13:38 [patch -next] bcma: signedness bug in bcma_get_next_core() Dan Carpenter
2011-08-20 12:23 ` Rafał Miłecki
2011-08-20 12:59 ` walter harms
2011-08-20 13:31 ` Rafał Miłecki
2011-08-23 19:13 ` Dan Carpenter
2011-08-24 10:01 ` Rafał Miłecki
2011-08-24 10:17 ` Dan Carpenter
2011-08-23 19:15 ` [patch -next v2] " Dan Carpenter
2011-08-20 14:11 ` walter harms [this message]
2011-08-20 14:17 ` [patch -next] " Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4FC09A.3080603@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox