From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Sat, 20 Aug 2011 14:11:38 +0000 Subject: Re: [patch -next] bcma: signedness bug in bcma_get_next_core() Message-Id: <4E4FC09A.3080603@bfs.de> List-Id: References: <20110818133809.GG4786@shale.localdomain> In-Reply-To: <20110818133809.GG4786@shale.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: kernel-janitors@vger.kernel.org Am 20.08.2011 15:31, schrieb Rafał Miłecki: > W dniu 20 sierpnia 2011 14:59 użytkownik walter harms napisał: >> >> >> Am 20.08.2011 14:23, schrieb Rafał Miłecki: >>> W dniu 18 sierpnia 2011 15:38 użytkownik Dan Carpenter >>> napisał: >>>> The u32 would never be less than zero so the error handling would >>>> break. I changed it to int. >>> >>> In declaration we use s32: >>> static s32 bcma_erom_get_mst_port(struct bcma_bus *bus, u32 **eromptr); >>> >>> Doesn't it sound better to use s32 instead of int? >>> >> >> aktualy int sounds better that s32 for me. > > Will you care to replace function return type as well? > not me, i would have to download a decent kernel etc, just to change an s32 into int. re, wh