Re: [patch -next] bcma: signedness bug in bcma_get_next_core()

Rafał Miłecki
2011-08-20T12:23:56Z

W dniu 18 sierpnia 2011 15:38 użytkownik Dan Carpenter
<error27@gmail.com> napisał:
> The u32 would never be less than zero so the error handling would
> break.  I changed it to int.

In declaration we use s32:
static s32 bcma_erom_get_mst_port(struct bcma_bus *bus, u32 **eromptr);

Doesn't it sound better to use s32 instead of int?

--
Rafał