From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Finger Date: Sat, 29 Oct 2011 01:05:52 +0000 Subject: Re: [PATCH 1/5] drivers/staging/rtl8712/rtl871x_mlme.c: eliminate Message-Id: <4EAB5170.8000407@lwfinger.net> List-Id: References: <1319846297-2985-1-git-send-email-julia@diku.dk> In-Reply-To: <1319846297-2985-1-git-send-email-julia@diku.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Florian Schilhabel , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org On 10/28/2011 06:58 PM, Julia Lawall wrote: > From: Julia Lawall > > If ibss_wlan is NULL, it is not correct to memcpy into its field. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @r@ > expression E, E1; > identifier f; > statement S1,S2,S3; > @@ > > if (E = NULL) > { > ... when != if (E = NULL || ...) S1 else S2 > when != E = E1 > *E->f > ... when any > return ...; > } > else S3 > // > > Signed-off-by: Julia Lawall > > --- > I have no idea whether this is the correct fix. I believe it is. It probably does not matter as I have never hit an oops at this location. Signed-off-by: Larry Finger > > drivers/staging/rtl8712/rtl871x_mlme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c > index ef8eb6c..4277d03 100644 > --- a/drivers/staging/rtl8712/rtl871x_mlme.c > +++ b/drivers/staging/rtl8712/rtl871x_mlme.c > @@ -551,7 +551,7 @@ void r8712_survey_event_callback(struct _adapter *adapter, u8 *pbuf) > ibss_wlan = r8712_find_network( > &pmlmepriv->scanned_queue, > pnetwork->MacAddress); > - if (!ibss_wlan) { > + if (ibss_wlan) { > memcpy(ibss_wlan->network.IEs, > pnetwork->IEs, 8); > goto exit; > >