* [patch] Staging: iio/dac/ad5064.c: signedness bug in
@ 2011-10-29 7:20 Dan Carpenter
2011-10-30 10:44 ` [patch] Staging: iio/dac/ad5064.c: signedness bug in ad5064_read_raw() Lars-Peter Clausen
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2011-10-29 7:20 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Greg Kroah-Hartman, Lars-Peter Clausen, linux-iio, devel,
kernel-janitors
regulator_get_voltage() returns an int so "scale_uv" should be an
int. Making it unsigned here breaks the error handling.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/iio/dac/ad5064.c b/drivers/staging/iio/dac/ad5064.c
index 24279f2..3b14526 100644
--- a/drivers/staging/iio/dac/ad5064.c
+++ b/drivers/staging/iio/dac/ad5064.c
@@ -280,8 +280,8 @@ static int ad5064_read_raw(struct iio_dev *indio_dev,
long m)
{
struct ad5064_state *st = iio_priv(indio_dev);
- unsigned long scale_uv;
unsigned int vref;
+ int scale_uv;
switch (m) {
case 0:
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] Staging: iio/dac/ad5064.c: signedness bug in ad5064_read_raw()
2011-10-29 7:20 [patch] Staging: iio/dac/ad5064.c: signedness bug in Dan Carpenter
@ 2011-10-30 10:44 ` Lars-Peter Clausen
2011-10-31 11:22 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Peter Clausen @ 2011-10-30 10:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jonathan Cameron, Greg Kroah-Hartman, linux-iio, devel,
kernel-janitors
On 10/29/2011 09:20 AM, Dan Carpenter wrote:
> regulator_get_voltage() returns an int so "scale_uv" should be an
> int. Making it unsigned here breaks the error handling.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
uhm, yes...
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
>
> diff --git a/drivers/staging/iio/dac/ad5064.c b/drivers/staging/iio/dac/ad5064.c
> index 24279f2..3b14526 100644
> --- a/drivers/staging/iio/dac/ad5064.c
> +++ b/drivers/staging/iio/dac/ad5064.c
> @@ -280,8 +280,8 @@ static int ad5064_read_raw(struct iio_dev *indio_dev,
> long m)
> {
> struct ad5064_state *st = iio_priv(indio_dev);
> - unsigned long scale_uv;
> unsigned int vref;
> + int scale_uv;
>
> switch (m) {
> case 0:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] Staging: iio/dac/ad5064.c: signedness bug in ad5064_read_raw()
2011-10-30 10:44 ` [patch] Staging: iio/dac/ad5064.c: signedness bug in ad5064_read_raw() Lars-Peter Clausen
@ 2011-10-31 11:22 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2011-10-31 11:22 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Dan Carpenter, Greg Kroah-Hartman, linux-iio, devel,
kernel-janitors
On 10/30/11 10:44, Lars-Peter Clausen wrote:
> On 10/29/2011 09:20 AM, Dan Carpenter wrote:
>> regulator_get_voltage() returns an int so "scale_uv" should be an
>> int. Making it unsigned here breaks the error handling.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> uhm, yes...
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>
> Thanks.
>
>>
>> diff --git a/drivers/staging/iio/dac/ad5064.c b/drivers/staging/iio/dac/ad5064.c
>> index 24279f2..3b14526 100644
>> --- a/drivers/staging/iio/dac/ad5064.c
>> +++ b/drivers/staging/iio/dac/ad5064.c
>> @@ -280,8 +280,8 @@ static int ad5064_read_raw(struct iio_dev *indio_dev,
>> long m)
>> {
>> struct ad5064_state *st = iio_priv(indio_dev);
>> - unsigned long scale_uv;
>> unsigned int vref;
>> + int scale_uv;
>>
>> switch (m) {
>> case 0:
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-31 11:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-29 7:20 [patch] Staging: iio/dac/ad5064.c: signedness bug in Dan Carpenter
2011-10-30 10:44 ` [patch] Staging: iio/dac/ad5064.c: signedness bug in ad5064_read_raw() Lars-Peter Clausen
2011-10-31 11:22 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox