* [patch] Staging: iio/dac/ad5360.c: signedness bug in
@ 2011-10-29 7:21 Dan Carpenter
2011-10-30 10:45 ` [patch] Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw() Lars-Peter Clausen
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2011-10-29 7:21 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Greg Kroah-Hartman, Lars-Peter Clausen, Michael Hennerich,
linux-iio, devel, kernel-janitors
ad5360_get_channel_vref() returns an int and scale_uv should be the
same. Making it unsigned here breaks the error handling.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/iio/dac/ad5360.c b/drivers/staging/iio/dac/ad5360.c
index 72d0f3f..cfeea72 100644
--- a/drivers/staging/iio/dac/ad5360.c
+++ b/drivers/staging/iio/dac/ad5360.c
@@ -371,8 +371,8 @@ static int ad5360_read_raw(struct iio_dev *indio_dev,
long m)
{
struct ad5360_state *st = iio_priv(indio_dev);
- unsigned long scale_uv;
unsigned int ofs_index;
+ int scale_uv;
int ret;
switch (m) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw()
2011-10-29 7:21 [patch] Staging: iio/dac/ad5360.c: signedness bug in Dan Carpenter
@ 2011-10-30 10:45 ` Lars-Peter Clausen
2011-10-31 11:22 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Peter Clausen @ 2011-10-30 10:45 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jonathan Cameron, Greg Kroah-Hartman, Michael Hennerich,
linux-iio, devel, kernel-janitors
On 10/29/2011 09:21 AM, Dan Carpenter wrote:
> ad5360_get_channel_vref() returns an int and scale_uv should be the
> same. Making it unsigned here breaks the error handling.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> diff --git a/drivers/staging/iio/dac/ad5360.c b/drivers/staging/iio/dac/ad5360.c
> index 72d0f3f..cfeea72 100644
> --- a/drivers/staging/iio/dac/ad5360.c
> +++ b/drivers/staging/iio/dac/ad5360.c
> @@ -371,8 +371,8 @@ static int ad5360_read_raw(struct iio_dev *indio_dev,
> long m)
> {
> struct ad5360_state *st = iio_priv(indio_dev);
> - unsigned long scale_uv;
> unsigned int ofs_index;
> + int scale_uv;
> int ret;
>
> switch (m) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw()
2011-10-30 10:45 ` [patch] Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw() Lars-Peter Clausen
@ 2011-10-31 11:22 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2011-10-31 11:22 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Dan Carpenter, Greg Kroah-Hartman, Michael Hennerich, linux-iio,
devel, kernel-janitors
On 10/30/11 10:45, Lars-Peter Clausen wrote:
> On 10/29/2011 09:21 AM, Dan Carpenter wrote:
>> ad5360_get_channel_vref() returns an int and scale_uv should be the
>> same. Making it unsigned here breaks the error handling.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23cam.ac.uk>
>
> Thanks.
>
>> diff --git a/drivers/staging/iio/dac/ad5360.c b/drivers/staging/iio/dac/ad5360.c
>> index 72d0f3f..cfeea72 100644
>> --- a/drivers/staging/iio/dac/ad5360.c
>> +++ b/drivers/staging/iio/dac/ad5360.c
>> @@ -371,8 +371,8 @@ static int ad5360_read_raw(struct iio_dev *indio_dev,
>> long m)
>> {
>> struct ad5360_state *st = iio_priv(indio_dev);
>> - unsigned long scale_uv;
>> unsigned int ofs_index;
>> + int scale_uv;
>> int ret;
>>
>> switch (m) {
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-31 11:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-29 7:21 [patch] Staging: iio/dac/ad5360.c: signedness bug in Dan Carpenter
2011-10-30 10:45 ` [patch] Staging: iio/dac/ad5360.c: signedness bug in ad5360_read_raw() Lars-Peter Clausen
2011-10-31 11:22 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox