From: "H. Peter Anvin" <hpa@zytor.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] x86: dubious one-bit signed bitfields
Date: Wed, 07 Dec 2011 18:14:11 +0000 [thread overview]
Message-ID: <4EDFACF3.5070201@zytor.com> (raw)
In-Reply-To: <20111207063848.GA14507@elgon.mountain>
On 12/06/2011 11:58 PM, Dan Carpenter wrote:
>
> Sure. Bool takes one byte, so it would be: bool
> sig_on_uaccess_error:1; bool uaccess_err:1; /* uaccess failed
> */
>
> The __u8 types mean that we're trying to not polute the posix
> namespace? Does that affect bool? I'm not sure the rules with
> that.
>
If these headers are exported to userspace it might be unsuitable, and
yes, better mark them "unsigned". If they are kernel-only it doesn't
matter.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2011-12-07 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 6:38 [patch -next] x86: dubious one-bit signed bitfields Dan Carpenter
2011-12-07 7:39 ` H. Peter Anvin
2011-12-07 7:58 ` Dan Carpenter
2011-12-07 18:14 ` H. Peter Anvin [this message]
2011-12-15 13:45 ` Dan Carpenter
2011-12-15 16:38 ` Andy Lutomirski
2011-12-15 17:06 ` Dan Carpenter
2012-01-04 6:41 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDFACF3.5070201@zytor.com \
--to=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox