From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Thu, 26 Jan 2012 11:57:04 +0000 Subject: Re: [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap Message-Id: <4F213F90.8060007@bfs.de> List-Id: References: <1326362117-29371-1-git-send-email-Julia.Lawall@lip6.fr> <7FE21149F4667147B645348EC605788508FBDB@039-SN2MPN1-013.039d.mgd.msft.net> <20120124202203.GD1135@opensource.wolfsonmicro.com> <20120126110506.GB2611@pengutronix.de> In-Reply-To: <20120126110506.GB2611@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wolfram Sang Cc: Julia Lawall , Mark Brown , "alsa-devel@alsa-project.org" , Takashi Iwai , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dong Aisheng-B29396 , Liam Girdwood Am 26.01.2012 12:05, schrieb Wolfram Sang: >> @@ -666,18 +666,19 @@ static int mxs_saif_probe(struct platform_device *pdev) >> goto failed_get_resource; >> } >> >> - if (!request_mem_region(iores->start, resource_size(iores), >> - "mxs-saif")) { >> + if (!devm_request_mem_region(&pdev->dev, iores->start, >> + resource_size(iores), "mxs-saif")) { >> dev_err(&pdev->dev, "request_mem_region failed\n"); >> ret = -EBUSY; >> goto failed_get_resource; >> } >> >> - saif->base = ioremap(iores->start, resource_size(iores)); >> + saif->base = devm_ioremap(&pdev->dev, iores->start, >> + resource_size(iores)); > > devm_request_and_ioremap() to save even more code? > hi all, at first I am NOT the maintainer ... personally i would stay with Julia's patch and add devm_request_and_ioremap() in a second round. The devm stuff is brand new, and two steps here would allow to spot/locate problems more easy since structural changes are less intrusive in each step. re, wh