From: Boaz Harrosh <bharrosh@panasas.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] exofs: add a cap on the memcpy() size
Date: Mon, 30 Jan 2012 16:20:37 +0000 [thread overview]
Message-ID: <4F26C355.7030004@panasas.com> (raw)
In-Reply-To: <20120130075949.GA22364@elgon.mountain>
On 01/30/2012 04:01 PM, Dan Carpenter wrote:
> On Mon, Jan 30, 2012 at 03:50:05PM +0200, Boaz Harrosh wrote:
>> On 01/30/2012 03:44 PM, Dan Carpenter wrote:
>>> On Mon, Jan 30, 2012 at 03:37:29PM +0200, Boaz Harrosh wrote:
>>>> I think I'd like something like:
>>>> - memcpy(odi->systemid, dt_dev->systemid, odi->systemid_len);
>>>> + if (likely(odi->systemid_len))
>>>> + memcpy(odi->systemid, dt_dev->systemid, OSD_SYSTEMID_LEN);
>>>>
>>>> Which should also make the static checkers happy. What do you think?
>>>>
>>>
>>> Sounds good to me.
>>>
>>> regards,
>>> dan carpenter
>>>
>>
>> OK I'll make a patch. Please send your review-by
>
> Could you give me a Reported-by cookie instead? No one pays any
> special attention to Reviewed-by tags when they come from newbies
> like me... :P
>
> regards,
> dan carpenter
>
Sure, yes
Boaz
prev parent reply other threads:[~2012-01-30 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 7:59 [patch] exofs: add a cap on the memcpy() size Dan Carpenter
2012-01-30 13:37 ` Boaz Harrosh
2012-01-30 13:44 ` Dan Carpenter
2012-01-30 13:50 ` Boaz Harrosh
2012-01-30 14:01 ` Dan Carpenter
2012-01-30 16:20 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F26C355.7030004@panasas.com \
--to=bharrosh@panasas.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox