From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Date: Tue, 31 Jan 2012 17:45:30 +0000 Subject: Re: [patch] mtd: nand: fix printk() warnings Message-Id: <4F28359A.3010200@xenotime.net> List-Id: References: <20120131085405.GD22039@elgon.mountain> In-Reply-To: <20120131085405.GD22039@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, Mike Dunn , Robert Jarzmik , David Woodhouse , linux-mtd@lists.infradead.org On 01/31/2012 12:54 AM, Dan Carpenter wrote: > Gcc complains here: > drivers/mtd/nand/docg4.c: In function ‘probe_docg4’: > drivers/mtd/nand/docg4.c:1277:4: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘resource_size_t’ [-Wformat] > drivers/mtd/nand/docg4.c:1277:4: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘resource_size_t’ [-Wformat] > > We have a standard way of printing these using a format string > extension. > > Signed-off-by: Dan Carpenter Yes, this is preferable over my patch yesterday. Thanks. Acked-by: Randy Dunlap > > diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c > index 3ec1d10..8a0d7f6 100644 > --- a/drivers/mtd/nand/docg4.c > +++ b/drivers/mtd/nand/docg4.c > @@ -1272,9 +1272,7 @@ static int __init probe_docg4(struct platform_device *pdev) > > virtadr = ioremap(r->start, resource_size(r)); > if (!virtadr) { > - dev_err(dev, "Diskonchip ioremap failed: " > - "0x%x bytes at 0x%x\n", > - resource_size(r), r->start); > + dev_err(dev, "Diskonchip ioremap failed: %pR\n", r); > return -EIO; > } > > -- -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***