From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Date: Sat, 03 Mar 2012 07:00:28 +0000 Subject: Re: [patch] block, sx8: fix pointer math issue getting fw version Message-Id: <4F51C18C.5080903@kernel.dk> List-Id: References: <20120302190042.GB3951@elgon.mountain> <4F51C103.507@kernel.dk> In-Reply-To: <4F51C103.507@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Jeff Garzik , Tejun Heo , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 2012-03-03 07:58, Jens Axboe wrote: > On 2012-03-02 20:00, Dan Carpenter wrote: >> "mem" is type u8. We need parenthesis here or it screws up the pointer >> math probably leading to an oops. > > Applied, thanks Dan. I have marked it stable, too. Hmm wait Dan, seems to me that u8 pointer math should be equiv to char * pointer math and hence it'd work just fine. Are you sure this is a bug? -- Jens Axboe