From: Jiri Slaby <jslaby@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [patch v2] tty: cyclades: TIOCSERGETLSR should should store to a uint
Date: Tue, 06 Mar 2012 14:09:39 +0000 [thread overview]
Message-ID: <4F561AA3.6050600@suse.cz> (raw)
In-Reply-To: <20120305180711.GB26880@elgon.mountain>
On 03/05/2012 07:07 PM, Dan Carpenter wrote:
> TIOCSERGETLSR should be saved in a uint so the cast here to unsigned
> long is a bug.
>
> Reported-by: Jiri Slaby <jslaby@suse.cz>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
ACK. Thanks.
> ---
> v2: completely different from v1.
>
> diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
> index c9bf779..5575fee 100644
> --- a/drivers/tty/cyclades.c
> +++ b/drivers/tty/cyclades.c
> @@ -2413,7 +2413,7 @@ static int get_lsr_info(struct cyclades_port *info, unsigned int __user *value)
> /* Not supported yet */
> return -EINVAL;
> }
> - return put_user(result, (unsigned long __user *)value);
> + return put_user(result, value);
> }
>
> static int cy_tiocmget(struct tty_struct *tty)
--
js
suse labs
prev parent reply other threads:[~2012-03-06 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 6:49 [patch] tty: cyclades: clean up a type issue Dan Carpenter
2012-03-02 19:21 ` Jiri Slaby
2012-03-05 18:07 ` [patch v2] tty: cyclades: TIOCSERGETLSR should should store to a uint Dan Carpenter
2012-03-06 14:09 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F561AA3.6050600@suse.cz \
--to=jslaby@suse.cz \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).