From: Trilok Soni <tsoni@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Ravi Kumar V <kumarrav@codeaurora.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [patch] [media] gpio-ir-recv: a couple signedness bugs
Date: Sun, 11 Mar 2012 19:50:22 +0000 [thread overview]
Message-ID: <4F5D01C5.4090101@codeaurora.org> (raw)
In-Reply-To: <20120310085818.GC4647@elgon.mountain>
Hi Dan,
On 3/10/2012 2:28 PM, Dan Carpenter wrote:
> There are couple places where we check unsigned values for negative. I
> changed ->gpin_nr to signed because in gpio_ir_recv_probe() we do:
> if (pdata->gpio_nr< 0)
> return -EINVAL;
> I also change gval to a signed int in gpio_ir_recv_irq() because that's
> the type that gpio_get_value_cansleep() returns and we test for negative
> returns.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>
Thanks.
Reviewed-by: Trilok Soni <tsoni@codeaurora.org>
---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
prev parent reply other threads:[~2012-03-11 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-10 8:58 [patch] [media] gpio-ir-recv: a couple signedness bugs Dan Carpenter
2012-03-11 19:50 ` Trilok Soni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5D01C5.4090101@codeaurora.org \
--to=tsoni@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kumarrav@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).