From: Larry Finger <Larry.Finger@lwfinger.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: rtl8192e: remove some dead code
Date: Tue, 17 Apr 2012 17:39:45 +0000 [thread overview]
Message-ID: <4F8DAAE1.7020909@lwfinger.net> (raw)
In-Reply-To: <20120417064558.GA29411@elgon.mountain>
On 04/17/2012 01:45 AM, Dan Carpenter wrote:
> We don't use the rxcmdpkt[] counters at all and we can remove them.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
> index 2a2519c..cebb748 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
> @@ -353,7 +353,6 @@ struct rt_stats {
> unsigned long rxrdu;
> unsigned long rxok;
> unsigned long rxframgment;
> - unsigned long rxcmdpkt[8];
> unsigned long rxurberr;
> unsigned long rxstaterr;
> unsigned long rxdatacrcerr;
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
> index 58d044e..ea91744 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
> @@ -342,7 +342,6 @@ static void cmpk_handle_tx_rate_history(struct net_device *dev, u8 *pmsg)
> u32 cmpk_message_handle_rx(struct net_device *dev,
> struct rtllib_rx_stats *pstats)
> {
> - struct r8192_priv *priv = rtllib_priv(dev);
> int total_length;
> u8 cmd_length, exe_cnt = 0;
> u8 element_id;
> @@ -409,8 +408,6 @@ u32 cmpk_message_handle_rx(struct net_device *dev,
> return 1;
> }
>
> - priv->stats.rxcmdpkt[element_id]++;
> -
> total_length -= cmd_length;
> pcmd_buff += cmd_length;
> }
>
prev parent reply other threads:[~2012-04-17 17:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 6:45 [patch] Staging: rtl8192e: remove some dead code Dan Carpenter
2012-04-17 17:39 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8DAAE1.7020909@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox