Re: [patch] rbd: use gfp_flags parameter in rbd_header_from_disk()

[Alex Elder <elder@dreamhost.com>]

On 03/22/2012 01:33 AM, Dan Carpenter wrote:
> We should use the gfp_flags that the caller specified instead of
> GFP_KERNEL here.
>
> There is only one caller and it uses GFP_KERNEL, so this change is just
> a cleanup and doesn't change how the code works.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>

This looks good.  Sorry it didn't get committed earlier.

Reviewed-by: Alex Elder <elder@dreamhost.com>

> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index a6278e7..fc9341f 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -474,11 +474,11 @@ static int rbd_header_from_disk(struct rbd_image_header *header,
>   		return -ENOMEM;
>   	if (snap_count) {
>   		header->snap_names = kmalloc(header->snap_names_len,
> -					     GFP_KERNEL);
> +					     gfp_flags);
>   		if (!header->snap_names)
>   			goto err_snapc;
>   		header->snap_sizes = kmalloc(snap_count * sizeof(u64),
> -					     GFP_KERNEL);
> +					     gfp_flags);
>   		if (!header->snap_sizes)
>   			goto err_names;
>   	} else {
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>