From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Arend van Spriel" <arend@broadcom.com>
Date: Tue, 15 May 2012 14:21:24 +0000
Subject: Re: [patch] brcm80211: brcmu_pkt_buf_free_skb() should handle NULL
Message-Id: <4FB26664.2080008@broadcom.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20120515090027.GG30265@elgon.mountain>
In-Reply-To: <20120515090027.GG30265@elgon.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Brett Rudley <brudley@broadcom.com>, Roland Vossen <rvossen@broadcom.com>, "Franky (Zhenhui) Lin" <frankyl@broadcom.com>, Kan Yan <kanyan@broadcom.com>, "John W. Linville" <linville@tuxdriver.com>, Greg Kroah-Hartman <gregkh@suse.de>, Pieter-Paul Giesberts <pieterpg@broadcom.com>, linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org

On 05/15/2012 11:00 AM, Dan Carpenter wrote:
> This is potentially called with NULL pointers, for example, look at
> brcmf_c_prec_enq().  Since it's a free() function, probably people
> expect it to handle NULL pointers.

Acked-by: Arend van Spriel <arend@broadcom.com>

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
> index b45ab34..3e6405e 100644

Is the diff command filtered properly here. In most patches I usually
see '---' immediatly after the Signed-off-by line.

> --- a/drivers/net/wireless/brcm80211/brcmutil/utils.c
> +++ b/drivers/net/wireless/brcm80211/brcmutil/utils.c
> @@ -43,6 +43,8 @@ EXPORT_SYMBOL(brcmu_pkt_buf_get_skb);
>  /* Free the driver packet. Free the tag if present */
>  void brcmu_pkt_buf_free_skb(struct sk_buff *skb)
>  {
> +	if (!skb)
> +		return;
>  	WARN_ON(skb->next);
>  	if (skb->destructor)
>  		/* cannot kfree_skb() on hard IRQ (net/core/skbuff.c) if
> 

Gr. AvS