From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Date: Mon, 11 Jun 2012 17:42:57 +0000 Subject: Re: [patch] can: c_can: precedence error in c_can_chip_config() Message-Id: <4FD62E21.3020209@hartkopp.net> List-Id: References: <20120609155150.GA6488@elgon.mountain> <4FD4DEF2.6070802@pengutronix.de> In-Reply-To: <4FD4DEF2.6070802@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Marc Kleine-Budde Cc: Dan Carpenter , Wolfgang Grandegger , AnilKumar Ch , "David S. Miller" , Jiri Kosina , linux-can@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On 10.06.2012 19:52, Marc Kleine-Budde wrote: > On 06/09/2012 05:56 PM, Dan Carpenter wrote: >> (CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which >> is zero so the condition is never true. The intent here was to test >> that both flags were set. >> >> Signed-off-by: Dan Carpenter >> --- >> This is a static checker fix. I'm not super familiar with the c_can >> code. > > Good catch. Applied to can-next. > > Marc > Shouldn't this fix go through the net-tree and stable instead of net-next? Regards, Oliver