From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Dominique Martinet <asmadeus@codewreck.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>,
"Gilles Muller" <Gilles.Muller@lip6.fr>,
"Michal Marek" <michal.lkml@markovi.net>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [v2] Coccinelle: Replace strncpy() + truncation by strscpy()
Date: Sat, 14 Jul 2018 14:34:55 +0000 [thread overview]
Message-ID: <4bbe41a6-a9c6-ddd7-6683-14c792c16de0@users.sourceforge.net> (raw)
In-Reply-To: <1531555951-9627-1-git-send-email-asmadeus@codewreck.org>
I would like to contribute another bit of patch review for your proposal.
https://patchwork.kernel.org/patch/10524633/
https://lore.kernel.org/lkml/1531555951-9627-1-git-send-email-asmadeus@codewreck.org/
* I have noticed that an action word was missing in the commit subject.
* The commit description was started with the wording “Besides being simpler, …”.
I would prefer an other ordering of information there.
It seems that the mentioned compilation error gave you motivation for
the shown source code transformation.
I suggest to move the concrete update suggestion behind it.
> +virtual patch
> +virtual report
> +virtual org
How do you think about to reduce a bit of code repetition?
+virtual patch, report, org
> In particular, I have conciously not removed the intermediate msg
> variable; as I made the message longer I actually added one more of
> these for the org mode section.
I propose again to reconsider such an implementation detail once more
so that unnecessary Python code could be avoided.
The Linux coding style supports the usage of long message strings.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id-b39a2f491a48ec740e0214a7dd584eefc2137d#n81
Can string literals be nicer than extra variables (because of questionable
source code layout concerns)?
Regards,
Markus
parent reply other threads:[~2018-07-14 14:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1531555951-9627-1-git-send-email-asmadeus@codewreck.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bbe41a6-a9c6-ddd7-6683-14c792c16de0@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Gilles.Muller@lip6.fr \
--cc=asmadeus@codewreck.org \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=ville.syrjala@linux.intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox