From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Date: Tue, 24 Jul 2018 16:42:33 +0000 Subject: Re: [PATCH] usb: usbip: remove redundant pointer ep Message-Id: <4c77677e-a9b2-7482-9121-e3d94c9b8802@kernel.org> List-Id: References: <20180713104501.11482-1-colin.king@canonical.com> In-Reply-To: <20180713104501.11482-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , Valentina Manea , Greg Kroah-Hartman , linux-usb@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan On 07/13/2018 04:45 AM, Colin King wrote: > From: Colin Ian King > > Pointer ep is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > warning: variable 'ep' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > --- > drivers/usb/usbip/vudc_dev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c > index 1b9a4f87db59..1634d8698e15 100644 > --- a/drivers/usb/usbip/vudc_dev.c > +++ b/drivers/usb/usbip/vudc_dev.c > @@ -279,12 +279,10 @@ static int vep_disable(struct usb_ep *_ep) > static struct usb_request *vep_alloc_request(struct usb_ep *_ep, > gfp_t mem_flags) > { > - struct vep *ep; > struct vrequest *req; > > if (!_ep) > return NULL; > - ep = to_vep(_ep); > > req = kzalloc(sizeof(*req), mem_flags); > if (!req) > Thanks for the patch. Looks good to me. Acked-by: Shuah Khan (Samsung OSG) thanks, -- Shuah