From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 23 Aug 2017 08:28:41 +0000 Subject: [PATCH 5/6] ALSA: timer: Adjust a condition check in snd_timer_resolution() Message-Id: <4d1a6d05-6574-b1f4-80ee-59cb5238a74e@users.sourceforge.net> List-Id: References: <800d7aa6-d8f2-cbf5-caaa-7e4006976e68@users.sourceforge.net> In-Reply-To: <800d7aa6-d8f2-cbf5-caaa-7e4006976e68@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: alsa-devel@alsa-project.org, Arnd Bergmann , Arvind Yadav , Dan Carpenter , Ingo Molnar , Jaroslav Kysela , Takashi Iwai , Takashi Sakamoto , Vegard Nossum Cc: kernel-janitors@vger.kernel.org, LKML From: Markus Elfring Date: Wed, 23 Aug 2017 09:45:06 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring --- sound/core/timer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/core/timer.c b/sound/core/timer.c index 6d73a63f6e2b..6cdd04a45962 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -395,5 +395,6 @@ unsigned long snd_timer_resolution(struct snd_timer_instance *timeri) return 0; - if ((timer = timeri->timer) != NULL) { + timer = timeri->timer; + if (timer) { if (timer->hw.c_resolution) return timer->hw.c_resolution(timer); return timer->hw.resolution; -- 2.14.0