Re: [PATCH] [media] gspca: dubious one-bit signed bitfield

[Hans de Goede <hdegoede@redhat.com>]

Hi,

Thanks for the patch, I've added it to my tree for 3.7:
http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.7-wip

Regards,

Hans



On 08/05/2012 02:34 PM, Emil Goode wrote:
> This patch changes some signed integers to unsigned because
> they are not intended for negative values and sparse
> is making noise about it.
>
> Sparse gives eight of these errors:
> drivers/media/video/gspca/ov519.c:144:29: error: dubious one-bit signed bitfield
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
>   drivers/media/video/gspca/ov519.c |   16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/video/gspca/ov519.c b/drivers/media/video/gspca/ov519.c
> index bfc7cef..c1a21bf 100644
> --- a/drivers/media/video/gspca/ov519.c
> +++ b/drivers/media/video/gspca/ov519.c
> @@ -141,14 +141,14 @@ enum sensors {
>
>   /* table of the disabled controls */
>   struct ctrl_valid {
> -	int has_brightness:1;
> -	int has_contrast:1;
> -	int has_exposure:1;
> -	int has_autogain:1;
> -	int has_sat:1;
> -	int has_hvflip:1;
> -	int has_autobright:1;
> -	int has_freq:1;
> +	unsigned int has_brightness:1;
> +	unsigned int has_contrast:1;
> +	unsigned int has_exposure:1;
> +	unsigned int has_autogain:1;
> +	unsigned int has_sat:1;
> +	unsigned int has_hvflip:1;
> +	unsigned int has_autobright:1;
> +	unsigned int has_freq:1;
>   };
>
>   static const struct ctrl_valid valid_controls[] = {
>