* [patch] [SCSI] mvsas: fix a && vs & bug
@ 2012-08-16 11:04 Dan Carpenter
2012-08-16 15:23 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-08-16 11:04 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: Xiangliang Yu, linux-scsi, linux-kernel, kernel-janitors
The "1 << (slot_idx % 32)" condition is always true. The intent was to
test a bit field here using bitwise AND. We do the test correctly a few
lines later in the do while loop.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static checker fix. Untested. Would apply to the -stable kernel.
diff --git a/drivers/scsi/mvsas/mv_94xx.c b/drivers/scsi/mvsas/mv_94xx.c
index 7e423e5..16349aa 100644
--- a/drivers/scsi/mvsas/mv_94xx.c
+++ b/drivers/scsi/mvsas/mv_94xx.c
@@ -622,7 +622,7 @@ static void mvs_94xx_command_active(struct mvs_info *mvi, u32 slot_idx)
{
u32 tmp;
tmp = mvs_cr32(mvi, MVS_COMMAND_ACTIVE+(slot_idx >> 3));
- if (tmp && 1 << (slot_idx % 32)) {
+ if (tmp & 1 << (slot_idx % 32)) {
mv_printk("command active %08X, slot [%x].\n", tmp, slot_idx);
mvs_cw32(mvi, MVS_COMMAND_ACTIVE + (slot_idx >> 3),
1 << (slot_idx % 32));
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] [SCSI] mvsas: fix a && vs & bug
2012-08-16 11:04 [patch] [SCSI] mvsas: fix a && vs & bug Dan Carpenter
@ 2012-08-16 15:23 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2012-08-16 15:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, Xiangliang Yu, linux-scsi, linux-kernel,
kernel-janitors
On 08/16/2012 07:04 AM, Dan Carpenter wrote:
> The "1 << (slot_idx % 32)" condition is always true. The intent was to
> test a bit field here using bitwise AND. We do the test correctly a few
> lines later in the do while loop.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-16 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-16 11:04 [patch] [SCSI] mvsas: fix a && vs & bug Dan Carpenter
2012-08-16 15:23 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).