From: Jonathan Cameron <jic23@kernel.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@cam.ac.uk>,
kernel-janitors@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/iio/adc/at91_adc.c: use devm_ functions
Date: Thu, 16 Aug 2012 19:04:36 +0000 [thread overview]
Message-ID: <502D4444.9050400@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1208151119290.2000@localhost6.localdomain6>
On 08/15/2012 10:20 AM, Julia Lawall wrote:
>> devm_request_and_ioremap will already print a error messages on it's own if
>> something goes wrong. So strictly speaking this one is redundant, but I don't
>> think it is necessary to do a resend just for this, maybe you can remove the
>> extra dev_err when you apply the patch.
>
> Thanks for pointing that out. I will get rid of the messages in the future. That seems easier than figuring out how to
> adapt the message to the new function.
>
merged with that line removed as suggested. Thanks Julia and Lars-Peter.
next prev parent reply other threads:[~2012-08-16 19:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 10:09 [PATCH] drivers/iio/adc/at91_adc.c: use devm_ functions Julia Lawall
2012-07-31 12:36 ` Lars-Peter Clausen
2012-07-31 12:41 ` Julia Lawall
2012-07-31 13:09 ` Julia Lawall
2012-08-14 20:32 ` Jonathan Cameron
2012-08-15 9:02 ` Lars-Peter Clausen
2012-08-15 9:20 ` Julia Lawall
2012-08-16 19:04 ` Jonathan Cameron [this message]
2012-07-31 13:54 ` Julia Lawall
2012-07-31 14:23 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502D4444.9050400@kernel.org \
--to=jic23@kernel.org \
--cc=jic23@cam.ac.uk \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).