From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Date: Thu, 16 Aug 2012 19:04:36 +0000 Subject: Re: [PATCH] drivers/iio/adc/at91_adc.c: use devm_ functions Message-Id: <502D4444.9050400@kernel.org> List-Id: References: <1343729383-30073-1-git-send-email-Julia.Lawall@lip6.fr> <5017D148.6030006@metafoo.de> <502AB5F1.3050908@kernel.org> <502B658F.5040100@metafoo.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Lars-Peter Clausen , Jonathan Cameron , kernel-janitors@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org On 08/15/2012 10:20 AM, Julia Lawall wrote: >> devm_request_and_ioremap will already print a error messages on it's own if >> something goes wrong. So strictly speaking this one is redundant, but I don't >> think it is necessary to do a resend just for this, maybe you can remove the >> extra dev_err when you apply the patch. > > Thanks for pointing that out. I will get rid of the messages in the future. That seems easier than figuring out how to > adapt the message to the new function. > merged with that line removed as suggested. Thanks Julia and Lars-Peter.