From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Date: Mon, 10 Sep 2012 14:02:34 +0000 Subject: Re: [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token M Message-Id: <504DF2FA.2020200@parallels.com> List-Id: References: <20120910111638.GC9660@localhost> <20120910125759.GA11808@localhost> <504DE3DA.7000802@parallels.com> <20120910130617.GA11963@localhost> In-Reply-To: <20120910130617.GA11963@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Fengguang Wu Cc: kernel-janitors@vger.kernel.org, Linux Memory Management List On 09/10/2012 05:06 PM, Fengguang Wu wrote: > On Mon, Sep 10, 2012 at 04:58:02PM +0400, Glauber Costa wrote: >> On 09/10/2012 04:57 PM, Fengguang Wu wrote: >>> Glauber, >>> >>> The patch entitled >>> >>> sl[au]b: Allocate objects from memcg cache >>> >>> changes >>> >>> include/linux/slub_def.h | 15 ++++++++++----- >>> >>> which triggers this warning: >>> >>> drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined >>> >>> It's the MAX_LEVEL that is defined in include/linux/idr.h. >>> >>> MAX_LEVEL is obviously too generic. Better adding some prefix to it? >>> >> >> I don't see any MAX_LEVEL definition in this patch. You say it is >> defined in include/linux/idr.h, and as the diffstat shows, I am not >> touching this file. > > It's a rather *unexpected* side effect. You changed slub_def.h to > include memcontrol.h/cgroup.h which in turn includes idr.h. > Indeed. >> I think this needs patching independently. > > Yes, sure. And perhaps send it for quick inclusion before your patches? > I agree.