From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Mon, 10 Sep 2012 17:05:15 +0000
Subject: Re: [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from con
Message-Id: <504E1DCB.3000003@linutronix.de>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20120910164015.GA16252@localhost>
In-Reply-To: <20120910164015.GA16252@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On 09/10/2012 06:40 PM, Fengguang Wu wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git master
> head:   d9c88901337158c9f253a7de58a10b5125d61d26
> commit: 7a7322b0a5d984025dd4faea9098b8fef07f8d8f [33/36] usb: gadget: remove usb_gadget_controller_number()
>
> All sparse warnings:

Once again, thank you.

>    drivers/usb/gadget/f_acm.c:287:9: sparse: advancing past deep designator
>    drivers/usb/gadget/f_obex.c:60:9: sparse: advancing past deep designator
>    drivers/usb/gadget/f_serial.c:134:9: sparse: advancing past deep designator
>    drivers/usb/gadget/serial.c:66:9: sparse: advancing past deep designator

I don't get these. The purpose is an all NULL terminating entry. Could
this be a sparse bug or is the [] / {} switch not really good C code?

> + drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0)

I've sent a patch for this.

Sebastian