From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tilman Schmidt Date: Thu, 13 Sep 2012 09:52:27 +0000 Subject: Re: [PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree Message-Id: <5051ACDB.5030407@imap.cc> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------enig82CCBC75DD5C689D2297D630" List-Id: References: <1347462407-13499-9-git-send-email-peter.senna@gmail.com> In-Reply-To: <1347462407-13499-9-git-send-email-peter.senna@gmail.com> To: Peter Senna Tschudin Cc: Hansjoerg Lipp , kernel-janitors@vger.kernel.org, Karsten Keil , gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig82CCBC75DD5C689D2297D630 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Am 12.09.2012 17:06, schrieb Peter Senna Tschudin: > From: Peter Senna Tschudin >=20 > Remove useless kfree() and clean up code related to the removal. >=20 > The semantic patch that finds this problem is as follows: [...] >=20 > Signed-off-by: Peter Senna Tschudin Acked-by: Tilman Schmidt > --- > drivers/isdn/gigaset/common.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/commo= n.c > index aa41485..30a6b17 100644 > --- a/drivers/isdn/gigaset/common.c > +++ b/drivers/isdn/gigaset/common.c > @@ -1123,7 +1123,6 @@ struct gigaset_driver *gigaset_initdriver(unsigne= d minor, unsigned minors, > return drv; > =20 > error: > - kfree(drv->cs); > kfree(drv); > return NULL; > } This is indeed vestigial code, left in when another error path that needed it was removed. Though innocuous, it's better to remove it. Thanks, Tilman --=20 Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Unge=F6ffnet mindestens haltbar bis: (siehe R=FCckseite) --------------enig82CCBC75DD5C689D2297D630 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlBRrOcACgkQMdB4Whm86/ntSwCfT5hw2bM/EQH3o+ymlNaygg8j VyEAnjBVSKhlpTSGCaEJ4rFqXEDnyRSI =spk4 -----END PGP SIGNATURE----- --------------enig82CCBC75DD5C689D2297D630--