From: Jonathan Cameron <jic23@kernel.org>
To: "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Dan Carpenter <dan.carpenter@oracle.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch 2/2] HID: sensors: remove some unneeded checks
Date: Tue, 18 Sep 2012 20:52:38 +0000 [thread overview]
Message-ID: <5058DF16.20002@kernel.org> (raw)
In-Reply-To: <4FA419E87744DF4DAECD5BCE1214B7A919D527E5@ORSMSX108.amr.corp.intel.com>
I've add these both to the togreg branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
Will send onwards in a few days.
> Tested this and it works.
>
> -----Original Message-----
> From: Jiri Kosina [mailto:jkosina@suse.cz]
> Sent: Monday, September 17, 2012 4:00 AM
> To: Dan Carpenter
> Cc: Pandruvada, Srinivas; linux-input@vger.kernel.org; kernel-janitors@vger.kernel.org; Jonathan Cameron
> Subject: Re: [patch 2/2] HID: sensors: remove some unneeded checks
>
> On Fri, 14 Sep 2012, Dan Carpenter wrote:
>
>> "report_id" is unsigned so it's never less than zero. These checks
>> can be removed without any problem.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>
> Adding Jonathan to CC as well. Thanks.
>
>>
>> diff --git a/drivers/hid/hid-sensor-hub.c
>> b/drivers/hid/hid-sensor-hub.c index 0c93b10..22ec3c6 100644
>> --- a/drivers/hid/hid-sensor-hub.c
>> +++ b/drivers/hid/hid-sensor-hub.c
>> @@ -214,9 +214,6 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
>> struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
>> int ret = 0;
>>
>> - if (report_id < 0)
>> - return -EINVAL;
>> -
>> mutex_lock(&data->mutex);
>> report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
>> if (!report || (field_index >= report->maxfield)) { @@ -241,9
>> +238,6 @@ int sensor_hub_get_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
>> struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
>> int ret = 0;
>>
>> - if (report_id < 0)
>> - return -EINVAL;
>> -
>> mutex_lock(&data->mutex);
>> report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
>> if (!report || (field_index >= report->maxfield)) { @@ -271,9
>> +265,6 @@ int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev,
>> struct hid_report *report;
>> int ret_val = 0;
>>
>> - if (report_id < 0)
>> - return -EINVAL;
>> -
>> mutex_lock(&data->mutex);
>> memset(&data->pending, 0, sizeof(data->pending));
>> init_completion(&data->pending.ready);
>>
>
> --
> Jiri Kosina
> SUSE Labs
>
prev parent reply other threads:[~2012-09-18 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 6:53 [patch 2/2] HID: sensors: remove some unneeded checks Dan Carpenter
2012-09-17 10:59 ` Jiri Kosina
2012-09-17 15:21 ` Pandruvada, Srinivas
2012-09-18 20:52 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5058DF16.20002@kernel.org \
--to=jic23@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox