kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Harsh Kumar <harsh1kumar@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Patch1/2] Staging: winbond: checkpatch cleanup for wb35tx_s.h
Date: Wed, 26 Sep 2012 04:53:56 +0000	[thread overview]
Message-ID: <50628A55.4040009@gmail.com> (raw)
In-Reply-To: <50628557.3040607@gmail.com>

Please ignore this mail. I will resend the patches.
Really sorry.

On Wednesday 26 September 2012 10:02 AM, Harsh Kumar wrote:

> checkpatch cleanup for drivers/staging/winbond/wb35tx_s.h
> Changed c99 comments to c89 comments
> 
> diff -uprN a/drivers/staging/winbond/wb35tx_s.h b/drivers/staging/winbond/wb35tx_s.h
> --- a/drivers/staging/winbond/wb35tx_s.h
> +++ b/drivers/staging/winbond/wb35tx_s.h
> @@ -3,36 +3,32 @@
>  
>  #include "mds_s.h"
>  
> -//==================
> -// IS89C35 Tx related definition
> -//==================
> -#define TX_INTERFACE			0	// Interface 1
> -#define TX_PIPE					3	// endpoint 4
> -#define TX_INTERRUPT			1	// endpoint 2
> -#define MAX_INTERRUPT_LENGTH	64	// It must be 64 for EP2 hardware
> +/* IS89C35 Tx related definition */
> +#define TX_INTERFACE			0	/* Interface 1 */
> +#define TX_PIPE					3	/* Endpoint 4 */
> +#define TX_INTERRUPT			1	/* Endpoint 2 */
> +#define MAX_INTERRUPT_LENGTH	64	/* It must be 64 for EP2 hardware */
>  
>  
>  
> -//==================
> -// Internal variable for module
> -//==================
> +/* Internal variable for module */
>  
>  
>  struct wb35_tx {
> -	// For Tx buffer
> +	/* For Tx buffer */
>  	u8	TxBuffer[ MAX_USB_TX_BUFFER_NUMBER ][ MAX_USB_TX_BUFFER ];
>  
> -	// For Interrupt pipe
> +	/* For Interrupt pipe */
>  	u8	EP2_buf[MAX_INTERRUPT_LENGTH];
>  
> -	atomic_t	TxResultCount;// For thread control of EP2 931130.4.m
> -	atomic_t	TxFireCounter;// For thread control of EP4 931130.4.n
> +	atomic_t	TxResultCount; /* For thread control of EP2 931130.4.m */
> +	atomic_t	TxFireCounter; /* For thread control of EP4 931130.4.n */
>  	u32			ByteTransfer;
>  
> -	u32	    TxSendIndex;// The next index of Mds array to be sent
> -	u32	    EP2vm_state; // for EP2vm state
> -	u32	    EP4vm_state; // for EP4vm state
> -	u32	    tx_halt; // Stopping VM
> +	u32	    TxSendIndex; /* The next index of Mds array to be sent */
> +	u32	    EP2vm_state; /* for EP2vm state */
> +	u32	    EP4vm_state; /* for EP4vm state */
> +	u32	    tx_halt; /* Stopping VM */
>  
>  	struct urb *				Tx4Urb;
>  	struct urb *				Tx2Urb;
> @@ -40,8 +36,8 @@ struct wb35_tx {
>  	int		EP2VM_status;
>  	int		EP4VM_status;
>  
> -	u32	TxFillCount; // 20060928
> -	u32	TxTimer; // 20060928 Add if sending packet is greater than 13
> +	u32	TxFillCount; /* 20060928 */
> +	u32	TxTimer; /* 20060928 Add if sending packet is greater than 13 */
>  };
>  
>  #endif
> 



      reply	other threads:[~2012-09-26  4:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26  4:44 [Patch1/2] Staging: winbond: checkpatch cleanup for wb35tx_s.h Harsh Kumar
2012-09-26  4:53 ` Harsh Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50628A55.4040009@gmail.com \
    --to=harsh1kumar@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).