From: Glauber Costa <glommer@parallels.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [glommer-memcg:slab-common/slabinfo 18/21] mm/slab_common.c:196:6: sparse: symbol 'print_slabinf
Date: Fri, 28 Sep 2012 08:16:39 +0000 [thread overview]
Message-ID: <50655CE7.8060600@parallels.com> (raw)
On 09/28/2012 05:19 AM, Fengguang Wu wrote:
> Hi Glauber,
>
Fenghuang,
> FYI, there are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/glommer/memcg.git slab-common/slabinfo
> head: 0521160acc51bc8385807752e69dd38d976aef22
> commit: 162166afaaa413f42fc655f3a87140b9a08c0a6e [18/21] move print_slabinfo_header to slab_common.c
>
> + mm/slab_common.c:196:6: sparse: symbol 'print_slabinfo_header' was not declared. Should it be static?
I fixed that.
> --
> + mm/slub.c:1713:6: sparse: symbol 'init_kmem_cache_cpus' was not declared. Should it be static?
> + mm/slub.c:1938:5: sparse: symbol 'put_cpu_partial' was not declared. Should it be static?
> + mm/slub.c:1068:40: sparse: context imbalance in 'free_debug_processing' - different lock contexts for basic block
> + mm/slub.c:1856:28: sparse: context imbalance in 'deactivate_slab' - unexpected unlock
> + mm/slub.c:1885:44: sparse: context imbalance in 'unfreeze_partials' - unexpected unlock
> + mm/slub.c:2539:31: sparse: context imbalance in '__slab_free' - unexpected unlock
>
My patch does not touch those functions at all. (I checked in git blame,
and they are in the tree for a while now).
If you want to send a patch fixing this upstream, you can add my Acked-by
(I could do that too, but you deserve the credit!)
next reply other threads:[~2012-09-28 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 8:16 Glauber Costa [this message]
2012-09-28 8:31 ` [glommer-memcg:slab-common/slabinfo 18/21] mm/slab_common.c:196:6: sparse: symbol 'print_slabinf Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50655CE7.8060600@parallels.com \
--to=glommer@parallels.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox