From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH V2] ath/ath9k/ar9003_eeprom.c: Remove semicolon after if
Date: Mon, 01 Oct 2012 07:13:06 +0000 [thread overview]
Message-ID: <50694282.6060809@bfs.de> (raw)
Am 30.09.2012 22:56, schrieb Peter Senna Tschudin:
> The semantic patch that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r1@
> position p;
> @@
> if (...);@p
>
> @script:python@
> p0 << r1.p;
> @@
> // Emacs org-mode output
> cocci.print_main("", p0)
> cocci.print_secs("", p0)
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> NOTE: This patch changes the semantics.
>
> Changes from V1:
> Commit message
> Added a note about semantics change
>
> drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> index 5bbe505..189aeb2 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> @@ -2989,7 +2989,7 @@ static u32 ath9k_hw_ar9300_get_eeprom(struct ath_hw *ah,
> case EEP_PAPRD:
> if (AR_SREV_9462(ah))
> return false;
> - if (!ah->config.enable_paprd);
> + if (!ah->config.enable_paprd)
> return false;
> return !!(pBase->featureEnable & BIT(5));
> case EEP_CHAIN_MASK_REDUCE:
Hi Peter,
please be a bit more verbose in your description.
This patch actualy changes the behavier of the code (into the intended way).
Something like "fix brocken error check" is much more appropiate.
There is clearly a difference between a additional (useless) semicolon
and things like this.
re,
wh
next reply other threads:[~2012-10-01 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 7:13 walter harms [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-30 19:21 [PATCH] ath/ath9k/ar9003_eeprom.c: Remove unnecessary semicolon Peter Senna Tschudin
2012-09-30 20:56 ` [PATCH V2] ath/ath9k/ar9003_eeprom.c: Remove semicolon after if Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50694282.6060809@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox