From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Date: Thu, 04 Oct 2012 09:31:11 +0000 Subject: Re: [PATCH 3/20] drivers/net/can/sja1000/peak_pci.c: fix error return code Message-Id: <506D575F.4040402@pengutronix.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------enig5BEFDC20CFC64095788A0E8A" List-Id: References: <1349281090-10013-4-git-send-email-peter.senna@gmail.com> In-Reply-To: <1349281090-10013-4-git-send-email-peter.senna@gmail.com> To: Peter Senna Tschudin Cc: wg@grandegger.com, kernel-janitors@vger.kernel.org, davem@davemloft.net, jj@chaosbits.net, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5BEFDC20CFC64095788A0E8A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 10/03/2012 06:17 PM, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin >=20 > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. >=20 > A simplified version of the semantic match that finds this problem is a= s > follows: (http://coccinelle.lip6.fr/) >=20 > // > ( > if@p1 (\(ret < 0\|ret !=3D 0\)) > { ... return ret; } > | > ret@p1 =3D 0 > ) > ... when !=3D ret =3D e1 > when !=3D &ret > *if(...) > { > ... when !=3D ret =3D e2 > when forall > return ret; > } > // >=20 > Signed-off-by: Peter Senna Tschudin Applied to can. Tnx, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enig5BEFDC20CFC64095788A0E8A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBtV18ACgkQjTAFq1RaXHPUhACfZftbepPARo5phiUlDFxBOlhZ KCYAn3uW8Qr0gOg2wGr2nDG+Nf2mkV4/ =9Fva -----END PGP SIGNATURE----- --------------enig5BEFDC20CFC64095788A0E8A--