From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Date: Tue, 20 Nov 2012 04:55:03 +0000 Subject: Re: [patch] x86, UV: integer wrap bug in uv_hub_ipi_value() Message-Id: <50AB0D27.6090205@zytor.com> List-Id: References: <20121117151611.GB16900@elgon.mountain> <20121120004834.GE5060@sgi.com> <20121120042855.GE6186@mwanda> In-Reply-To: <20121120042855.GE6186@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Russ Anderson , Thomas Gleixner , Jack Steiner , Dimitri Sivanich , Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, rja@americas.sgi.com On 11/19/2012 08:28 PM, Dan Carpenter wrote: > > I do feel a little embarrassed that I didn't use "unsigned long" > consistently. I just used ulong to make the line a bit shorter, but > I could redo it with "unsigned long" if you want. > Yes, "ulong" is not idiomatic in the Linux kernel. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.