From: Ian Abbott <abbotti@mev.co.uk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: comedi: add a missing break statement
Date: Mon, 14 Jan 2013 10:11:56 +0000 [thread overview]
Message-ID: <50F3D9EC.6080007@mev.co.uk> (raw)
In-Reply-To: <20130113200504.GD5907@elgon.mountain>
On 2013-01-13 20:05, Dan Carpenter wrote:
> This is a static checker fix. From the context it looks like there
> should be a break here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Please review this carefully. I think it's probably correct, but I'd
> appreciate an Ack from someone who knows comedi better.
>
> diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c
> index 0c991b9..13747f3 100644
> --- a/drivers/staging/comedi/drivers/ni_tiocmd.c
> +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c
> @@ -159,6 +159,7 @@ static int ni_tio_input_cmd(struct ni_gpct *counter, struct comedi_async *async)
> async->inttrig = NULL;
> mite_dma_arm(counter->mite_chan);
> retval = ni_tio_arm(counter, 1, cmd->start_arg);
> + break;
> case TRIG_OTHER:
> async->inttrig = NULL;
> mite_dma_arm(counter->mite_chan);
>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2013-01-14 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 20:05 [patch] Staging: comedi: add a missing break statement Dan Carpenter
2013-01-14 10:11 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F3D9EC.6080007@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox