From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Date: Thu, 24 Sep 2015 23:55:39 +0000 Subject: Re: [patch] ACPI / tables: test the correct variable Message-Id: <5197324.W7Zx4mc8dA@vostro.rjw.lan> List-Id: References: <20150922122925.GA27407@mwanda> In-Reply-To: <20150922122925.GA27407@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Tuesday, September 22, 2015 03:29:25 PM Dan Carpenter wrote: > The intent was to test "proc[i].handler" instead of "proc->handler". > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > index c1ff58d..6c0f079 100644 > --- a/drivers/acpi/tables.c > +++ b/drivers/acpi/tables.c > @@ -268,7 +268,8 @@ acpi_parse_entries_array(char *id, unsigned long table_size, > for (i = 0; i < proc_num; i++) { > if (entry->type != proc[i].id) > continue; > - if (!proc->handler || proc[i].handler(entry, table_end)) > + if (!proc[i].handler || > + proc[i].handler(entry, table_end)) > return -EINVAL; > > proc->count++; > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Applied, thanks!