From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Wed, 29 May 2013 07:21:00 +0000 Subject: Re: [patch] leds: renesas-tpu: cleanup a small type issue Message-Id: <51A5AC5C.6060901@bfs.de> List-Id: References: <20130529070150.GC25133@debian> In-Reply-To: <20130529070150.GC25133@debian> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Am 29.05.2013 09:02, schrieb Dan Carpenter: > Static checkers complain that this is declared as an unsigned long > but we only ever use the low 32 bits (ignoring sign expansion). > But from the context, it should just be an unsigned short. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/leds/leds-renesas-tpu.c b/drivers/leds/leds-renesas-tpu.c > index 9483f1c..fe1fbd0 100644 > --- a/drivers/leds/leds-renesas-tpu.c > +++ b/drivers/leds/leds-renesas-tpu.c > @@ -93,7 +93,8 @@ static inline void r_tpu_write(struct r_tpu_priv *p, int reg_nr, > static void r_tpu_start_stop_ch(struct r_tpu_priv *p, int start) > { > struct led_renesas_tpu_config *cfg = p->pdev->dev.platform_data; > - unsigned long flags, value; > + unsigned long flags; > + unsigned short value; > When it is using the lower 32bit may "int" is better ? re, wh > /* start stop register shared by multiple timer channels */ > spin_lock_irqsave(&r_tpu_lock, flags); > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >