From: Randy Dunlap <rdunlap@infradead.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Emil Goode <emilgoode@gmail.com>,
balbi@ti.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
USB <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb: musb: Fix format specifier warning
Date: Fri, 31 May 2013 22:39:32 +0000 [thread overview]
Message-ID: <51A926A4.5010800@infradead.org> (raw)
In-Reply-To: <CAHp75VciHQKcyj-ANLdg=mg2C71zn=09Eentf22q+otGu=rp3w@mail.gmail.com>
On 05/31/13 15:34, Andy Shevchenko wrote:
> On Fri, May 31, 2013 at 11:22 PM, Emil Goode <emilgoode@gmail.com> wrote:
>> This patch fixes a format specifier warning. dma_addr_t can be either
>> u32 or u64 so we should cast to the largest type and change the format
>> specifier to %llx.
>
> dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier
> which is available from v3.8(?).
>
> Something like this:
> dma_addr_t src_addr;
> dev_dbg(dev, "DMA addr: %pa\n", src_addr);
Isn't that:
deb_dbg(dev, "DMA addr: %pa\n", &src_addr);
--
~Randy
next prev parent reply other threads:[~2013-05-31 22:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 20:22 [PATCH] usb: musb: Fix format specifier warning Emil Goode
2013-05-31 20:27 ` Sergei Shtylyov
2013-05-31 22:34 ` Andy Shevchenko
2013-05-31 22:39 ` Randy Dunlap [this message]
2013-06-01 13:15 ` Andy Shevchenko
2013-06-01 17:11 ` Emil Goode
2013-06-01 22:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A926A4.5010800@infradead.org \
--to=rdunlap@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=balbi@ti.com \
--cc=emilgoode@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox