From: Alex Elder <alex.elder@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sage Weil <sage@inktank.com>,
ceph-devel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [parch] ceph: cleanup types in striped_read()
Date: Tue, 23 Jul 2013 17:02:09 +0000 [thread overview]
Message-ID: <51EEB711.3030506@linaro.org> (raw)
In-Reply-To: <20130723134801.GA15116@longonot.mountain>
On 07/23/2013 08:48 AM, Dan Carpenter wrote:
> We pass in a u64 value for "len" and then immediately truncate away the
> upper 32 bits.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good.
Reviewed-by: Alex Elder <alex.elder@linaro.org>
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index 2ddf061..93e53c8 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -313,9 +313,9 @@ static int striped_read(struct inode *inode,
> {
> struct ceph_fs_client *fsc = ceph_inode_to_client(inode);
> struct ceph_inode_info *ci = ceph_inode(inode);
> - u64 pos, this_len;
> + u64 pos, this_len, left;
> int io_align, page_align;
> - int left, pages_left;
> + int pages_left;
> int read;
> struct page **page_pos;
> int ret;
> @@ -346,7 +346,7 @@ more:
> ret = 0;
> hit_stripe = this_len < left;
> was_short = ret >= 0 && ret < this_len;
> - dout("striped_read %llu~%u (read %u) got %d%s%s\n", pos, left, read,
> + dout("striped_read %llu~%llu (read %u) got %d%s%s\n", pos, left, read,
> ret, hit_stripe ? " HITSTRIPE" : "", was_short ? " SHORT" : "");
>
> if (ret > 0) {
> @@ -378,7 +378,7 @@ more:
> if (pos + left > inode->i_size)
> left = inode->i_size - pos;
>
> - dout("zero tail %d\n", left);
> + dout("zero tail %llu\n", left);
> ceph_zero_page_vector_range(page_align + read, left,
> pages);
> read += left;
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-07-23 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 13:48 [parch] ceph: cleanup types in striped_read() Dan Carpenter
2013-07-23 17:02 ` Alex Elder [this message]
2013-07-24 1:09 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EEB711.3030506@linaro.org \
--to=alex.elder@linaro.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox