From: Kumar Gaurav <kumargauravgupta3@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: Need clearance before sending patch
Date: Fri, 26 Jul 2013 16:23:02 +0000 [thread overview]
Message-ID: <51F29F96.9030309@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1307261746260.2266@hadrien>
On Friday 26 July 2013 09:21 PM, Julia Lawall wrote:
> On Fri, 26 Jul 2013, Kumar Gaurav wrote:
>
>> Hi Dan,
>>
>> I had sent my first patch with lots of changes which wasn't correct.
>> Now i'm splitting them in parts as below:
>> 1.One patch for variable name replacement (one patch per file)
>> 2.One Patch for fixing coding style issue (one patch per file)
>> 3.One Patch for fixing warning about using pr_warn,pr_error functions
>> instead of printk(KERN_WARNING... and printk(KERN_ERR... (havn't
>> replaced yet as last time you weren't convinced)
>>
>> please tell me that should i apply these patches per file or one patch
>> for replacement in all applied files?
>
> I wonder if one would be better off by starting with small isolated
> bugs, rather than these things that, even though they seem simple, are a
> bit pervasive and rely a lot on taste?
>
> Finding real bugs is not so hard. One can either use the various tools
> that are provided, or study the git logs to see what kind of bugs others
> have found.
>
> julia
Thanks for your reply Julia. I'll start looking for real bug right ahead
but want to fix with what i started so just waiting for answer or above
questions.
In mean while i'm looking at bugs and will try to fix them if i find any.
Thanks
Kumar gaurav
next prev parent reply other threads:[~2013-07-26 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 15:51 Need clearance before sending patch Julia Lawall
2013-07-26 15:55 ` Kumar Gaurav
2013-07-26 16:23 ` Kumar Gaurav [this message]
2013-07-26 20:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F29F96.9030309@gmail.com \
--to=kumargauravgupta3@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox