From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Sun, 11 Aug 2013 07:34:40 +0000 Subject: Re: [PATCH] arch/arm/mach-pxa/stargate2.c: use ARRAY_AND_SIZE consistently Message-Id: <52073E90.2030008@bfs.de> List-Id: References: <1376148353-9699-1-git-send-email-Julia.Lawall@lip6.fr> <20130810223338.GM5502@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Am 11.08.2013 07:48, schrieb Julia Lawall: > On Sun, 11 Aug 2013, Dan Carpenter wrote: > >> ARRAY_AND_SIZE() macro is horrible, and I would like it if it were >> removed. What I meant before was just that probably people will >> probably complain if we try to remove it. > > Well, I could either wait for someone to defend it, or send a patch > getting rid of it and see what happens... I can't see what could go wrong > with > > f(..., > - ARRAY_AND_SIZE(e) > + e, ARRAY_SIZE(e) > , ...) > > so it should be an easy patch to create. > if it is not to much work, send a patch to get rid of it. It seems all agree that the disadvantages outweighs it advantages. just my 2 cents, wh