From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 19 Aug 2013 14:29:37 +0000 Subject: Re: [PATCH 4/6 v2] usb: musb: dsps: simplify platform_get_resource_byname/devm_ioremap_resource Message-Id: <52122BD1.2090406@cogentembedded.com> List-Id: References: <1376902316-18520-1-git-send-email-Julia.Lawall@lip6.fr> <1376902316-18520-5-git-send-email-Julia.Lawall@lip6.fr> <5211FED3.4090102@secomea.dk> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Julia Lawall Cc: =?ISO-8859-1?Q?Svenning_S=F8rensen?= , Felipe Balbi , kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Hello. On 08/19/2013 03:47 PM, Julia Lawall wrote: > From: Julia Lawall > Remove unneeded error handling on the result of a call to > platform_get_resource_byname when the value is passed to > devm_ioremap_resource. > A simplified version of the semantic patch that makes this change is as > follows: (http://coccinelle.lip6.fr/) > // > @@ > expression pdev,res,e,e1; > expression ret !=3D 0; > identifier l; > @@ > > res =3D platform_get_resource_byname(...); > - if (res =3D NULL) { ... \(goto l;\|return ret;\) } > e =3D devm_ioremap_resource(e1, res); > // > This patch also adjusts the error-handling code on the call to > devm_ioremap_resource to check the right value, noticed by Svenning S=F8r= ensen. Saying "also" in the changelog is usuallly a good sign the patch should= be=20 split. > Signed-off-by: Julia Lawall > --- > v2: Fixed the bug on the test of the result of devm_ioremap_resource > drivers/usb/musb/musb_dsps.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c > index 4ffbaac..e60be6f 100644 > --- a/drivers/usb/musb/musb_dsps.c > +++ b/drivers/usb/musb/musb_dsps.c > @@ -357,12 +357,9 @@ static int dsps_musb_init(struct musb *musb) > u32 rev, val; > > r =3D platform_get_resource_byname(parent, IORESOURCE_MEM, "control"); > - if (!r) > - return -EINVAL; > - > reg_base =3D devm_ioremap_resource(dev, r); > - if (!musb->ctrl_base) > - return -EINVAL; > + if (IS_ERR(reg_base)) > + return PTR_ERR(reg_base); This is indented with space, not tabs. And of course, this was a matter= of=20 a separate *fix* patch, while the original patch was a *cleanup*. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html