From: Ian Abbott <abbotti@mev.co.uk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: comedi: pcl812: missing break statement
Date: Wed, 21 Aug 2013 10:44:01 +0000 [thread overview]
Message-ID: <521499F1.40709@mev.co.uk> (raw)
In-Reply-To: <20130821082804.GC5240@elgon.mountain>
On 2013-08-21 09:28, Dan Carpenter wrote:
> Smatch complains that there is a missing break statement here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This looks correct to me, but please double check.
>
> diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
> index 35251e7..03a0989 100644
> --- a/drivers/staging/comedi/drivers/pcl812.c
> +++ b/drivers/staging/comedi/drivers/pcl812.c
> @@ -1404,6 +1404,7 @@ no_dma:
> if (it->options[3] > 0)
> /* we use external trigger */
> devpriv->use_ext_trg = 1;
> + break;
> case boardA821:
> devpriv->max_812_ai_mode0_rangewait = 1;
> devpriv->mode_reg_int = (irq << 4) & 0xf0;
>
The missing break might be deliberate; I'll need to track down the
manuals for the affected cards. case boardACL8216 in the same switch
also has no break.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2013-08-21 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 8:28 [patch] staging: comedi: pcl812: missing break statement Dan Carpenter
2013-08-21 10:44 ` Ian Abbott [this message]
2013-08-21 11:35 ` Ian Abbott
2013-08-21 12:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521499F1.40709@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox