From: Larry Finger <Larry.Finger@lwfinger.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] staging: rtl8188eu: || vs && typo
Date: Sat, 31 Aug 2013 16:37:21 +0000 [thread overview]
Message-ID: <52221BC1.3040501@lwfinger.net> (raw)
In-Reply-To: <20130829214614.GC23197@elgon.mountain>
On 08/29/2013 04:46 PM, Dan Carpenter wrote:
> Obviously it's impossible for ->KeyLength to be both 5 and 13. I assume
> that && was intended here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
> index 5fab477..193f641 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
> @@ -743,7 +743,7 @@ _func_enter_;
>
> /* Check key length for WEP. For NDTEST, 2005.01.27, by rcnjko. */
> if ((encryptionalgo = _WEP40_ || encryptionalgo = _WEP104_) &&
> - (key->KeyLength != 5 || key->KeyLength != 13)) {
> + (key->KeyLength != 5 && key->KeyLength != 13)) {
> RT_TRACE(_module_rtl871x_ioctl_set_c_, _drv_err_, ("WEP KeyLength:0x%x != 5 or 13\n", key->KeyLength));
> ret = _FAIL;
> goto exit;
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
prev parent reply other threads:[~2013-08-31 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 21:46 [patch 2/2] staging: rtl8188eu: || vs && typo Dan Carpenter
2013-08-31 16:37 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52221BC1.3040501@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox