From: Alexander Holler <holler@ahsoftware.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch guide for newbies
Date: Tue, 24 Sep 2013 17:43:24 +0000 [thread overview]
Message-ID: <5241CF3C.8040403@ahsoftware.de> (raw)
In-Reply-To: <5241CB44.8080004@ahsoftware.de>
Am 24.09.2013 19:26, schrieb Alexander Holler:
> Am 24.09.2013 18:36, schrieb Bjorn Helgaas:
>> On Mon, Sep 23, 2013 at 3:01 AM, Dan Carpenter
>> <dan.carpenter@oracle.com> wrote:
>>> Long Lines
>>>
>>> Historically screens were 80 characters wide and it was annoying when
>>> code went
>>> over the edge. These days we have larger screens, but we keep the 80
>>> character
>>> limit because it forces us to write simpler code.
>
> Sorry, but that just isn't true and never was. Having a line wide limit
> of 80 characters while forcing tabs to be 8 characters long limits most
> code to just 72 characters. And even less (max 64) inside constructs
> like if, for or while.
>
> The only outcome of that totally silly rule is that variable names will
> become shorted to silly acronyms almost nobody does understand make code
> unreadable.
I forgot to mention function names, which are often even worse shortened
than variable names.
>
> I always feel like beeing in the IT stone age when programmers thought
> they have to use variable names like a, b and c to save storage, memory
> or to type less when reading linux kernel code.
>
> Regards,
>
> Alexander Holler
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-09-24 17:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 9:01 checkpatch guide for newbies Dan Carpenter
2013-09-23 12:46 ` Peter Senna Tschudin
2013-09-23 13:29 ` Dan Carpenter
2013-09-23 14:04 ` Geert Uytterhoeven
2013-09-23 18:06 ` Joe Perches
2013-09-23 20:17 ` Joe Perches
2013-09-23 18:35 ` bojan prtvar
2013-09-24 16:36 ` Bjorn Helgaas
2013-09-24 17:26 ` Alexander Holler
2013-09-24 17:43 ` Alexander Holler [this message]
2013-09-24 18:50 ` Alexander Holler
2013-09-24 19:29 ` Peter Senna Tschudin
2013-09-24 19:59 ` Dan Carpenter
2013-09-24 20:13 ` Bjorn Helgaas
2013-09-24 22:10 ` Alexander Holler
2013-09-26 2:11 ` Al Viro
2013-09-26 2:52 ` Alexander Holler
2013-09-26 2:57 ` Alexander Holler
2013-09-26 3:04 ` Al Viro
2013-09-26 3:27 ` Alexander Holler
2013-09-26 3:48 ` Al Viro
2013-09-26 4:21 ` Alexander Holler
2013-09-26 5:53 ` Julia Lawall
2013-09-26 9:55 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5241CF3C.8040403@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).