From: Alexander Holler <holler@ahsoftware.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Peter Senna Tschudin <peter.senna@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch guide for newbies
Date: Thu, 26 Sep 2013 02:52:21 +0000 [thread overview]
Message-ID: <5243A165.2060204@ahsoftware.de> (raw)
In-Reply-To: <20130926021130.GD13318@ZenIV.linux.org.uk>
Am 26.09.2013 04:11, schrieb Al Viro:
> On Wed, Sep 25, 2013 at 12:10:57AM +0200, Alexander Holler wrote:
>
>> Sure and I'm the last one who wants that people do have to use
>> anything else than i for simple loop counters. And allowing longer
>> lines doesn't mean people have to use long names, it allows them use
>> them (if it makes sense). That's a big difference.
>>
>> On the other side it's almost impossible to use verbose variable or
>> function names where they would make sense. Not to speak about all
>> the ugly splitted lines just to be below that ancient CGA limit.
>
> Yeah, the things people will do to avoid <gasp> not nesting the living
> hell out of their code...
>
> Tell you what - pick a random place where the code is nested 8 levels
> deep and I'm fairly sure that you will end up with your finger on one
> hell of ugliness. Ugliness in logical structure, not in forced line
> breaks. Let's experiment... Aha. In drivers/pci/hotplug/ibmphp_pci.c,
> 258 lines of deeply indented shite^Wcode that must be good since it compiles:
>
> <avert your eyes if you've got a weak stomach>
I'm aware of people which do nest 8 levels deep just to avoid a return,
break or goto.
But trying to limit that by limiting the line length is like ...
(choose your own own misguided comparison, it's too late for me I
currently only meorize some of those which don't make sense in english)
Regards,
Alexander Holler
next prev parent reply other threads:[~2013-09-26 2:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 9:01 checkpatch guide for newbies Dan Carpenter
2013-09-23 12:46 ` Peter Senna Tschudin
2013-09-23 13:29 ` Dan Carpenter
2013-09-23 14:04 ` Geert Uytterhoeven
2013-09-23 18:06 ` Joe Perches
2013-09-23 20:17 ` Joe Perches
2013-09-23 18:35 ` bojan prtvar
2013-09-24 16:36 ` Bjorn Helgaas
2013-09-24 17:26 ` Alexander Holler
2013-09-24 17:43 ` Alexander Holler
2013-09-24 18:50 ` Alexander Holler
2013-09-24 19:29 ` Peter Senna Tschudin
2013-09-24 19:59 ` Dan Carpenter
2013-09-24 20:13 ` Bjorn Helgaas
2013-09-24 22:10 ` Alexander Holler
2013-09-26 2:11 ` Al Viro
2013-09-26 2:52 ` Alexander Holler [this message]
2013-09-26 2:57 ` Alexander Holler
2013-09-26 3:04 ` Al Viro
2013-09-26 3:27 ` Alexander Holler
2013-09-26 3:48 ` Al Viro
2013-09-26 4:21 ` Alexander Holler
2013-09-26 5:53 ` Julia Lawall
2013-09-26 9:55 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5243A165.2060204@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).