From: Larry Finger <Larry.Finger@lwfinger.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: rtl8712: remove unneeded NULL check
Date: Mon, 30 Sep 2013 14:29:31 +0000 [thread overview]
Message-ID: <52498ACB.7090705@lwfinger.net> (raw)
In-Reply-To: <20130928095833.GE26611@elgon.mountain>
On 09/28/2013 04:58 AM, Dan Carpenter wrote:
> We knew "peventbuf" was a valid pointer and "peventbuf + 2" is also
> non-NULL. I have removed the check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c b/drivers/staging/rtl8712/rtl8712_cmd.c
> index 088647c..53f247b 100644
> --- a/drivers/staging/rtl8712/rtl8712_cmd.c
> +++ b/drivers/staging/rtl8712/rtl8712_cmd.c
> @@ -471,11 +471,9 @@ void r8712_event_handle(struct _adapter *padapter, uint *peventbuf)
> if (pevt_priv->event_seq > 127)
> pevt_priv->event_seq = 0;
> peventbuf = peventbuf + 2; /* move to event content, 8 bytes alignment */
> - if (peventbuf) {
> - event_callback = wlanevents[evt_code].event_callback;
> - if (event_callback)
> - event_callback(padapter, (u8 *)peventbuf);
> - }
> + event_callback = wlanevents[evt_code].event_callback;
> + if (event_callback)
> + event_callback(padapter, (u8 *)peventbuf);
> pevt_priv->evt_done_cnt++;
> _abort_event_:
> return;
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
prev parent reply other threads:[~2013-09-30 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 9:58 [patch] staging: rtl8712: remove unneeded NULL check Dan Carpenter
2013-09-30 14:29 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52498ACB.7090705@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).