From: Clemens Ladisch <clemens@ladisch.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] firewire: info leak in ioctl_get_info()
Date: Sat, 19 Oct 2013 10:24:30 +0000 [thread overview]
Message-ID: <52625DDE.8010802@ladisch.de> (raw)
In-Reply-To: <20131019091020.GE9312@longonot.mountain>
Dan Carpenter wrote:
> There is a 4 byte hole in the bus_reset struct at the end of the struct
> after ->generation.
queue_bus_reset_event() uses kzalloc(), and ioctl_get_info() does not copy
the hole.
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/firewire/core-cdev.c b/drivers/firewire/core-cdev.c
> index d7d5c8a..d34adb3 100644
> --- a/drivers/firewire/core-cdev.c
> +++ b/drivers/firewire/core-cdev.c
> @@ -353,6 +353,8 @@ static void fill_bus_reset_event(struct fw_cdev_event_bus_reset *event,
> {
> struct fw_card *card = client->device->card;
>
> + memset(event, 0, sizeof(*event));
> +
> spin_lock_irq(&card->lock);
>
> event->closure = client->bus_reset_closure;
Regards,
Clemens
next prev parent reply other threads:[~2013-10-19 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 9:10 [patch] firewire: info leak in ioctl_get_info() Dan Carpenter
2013-10-19 10:24 ` Clemens Ladisch [this message]
2013-10-19 11:03 ` Stefan Richter
2013-10-19 11:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52625DDE.8010802@ladisch.de \
--to=clemens@ladisch.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox