kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Archit Taneja <archit@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Grant Likely <grant.likely@linaro.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Kamil Debski <k.debski@samsung.com>,
	linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] v4l: ti-vpe: checking for IS_ERR() instead of NULL
Date: Fri, 08 Nov 2013 10:38:35 +0000	[thread overview]
Message-ID: <527CBC5B.2000906@ti.com> (raw)
In-Reply-To: <20131108100109.GN27977@elgon.mountain>

Hi Dan,

On Friday 08 November 2013 03:31 PM, Dan Carpenter wrote:
> devm_ioremap() returns NULL on error, it doesn't return an ERR_PTR.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c
> index 4e58069..e163466 100644
> --- a/drivers/media/platform/ti-vpe/vpe.c
> +++ b/drivers/media/platform/ti-vpe/vpe.c
> @@ -1962,8 +1962,8 @@ static int vpe_probe(struct platform_device *pdev)
>   	 * registers based on the sub block base addresses
>   	 */
>   	dev->base = devm_ioremap(&pdev->dev, res->start, SZ_32K);
> -	if (IS_ERR(dev->base)) {
> -		ret = PTR_ERR(dev->base);
> +	if (!dev->base) {
> +		ret = -ENOMEM;
>   		goto v4l2_dev_unreg;
>   	}

Thanks for the patch, this was addressed in Wei's patch though:

"v4l: ti-vpe: fix return value check in vpe_probe()"

Thanks,
Archit

      reply	other threads:[~2013-11-08 10:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08 10:01 [patch] [media] v4l: ti-vpe: checking for IS_ERR() instead of NULL Dan Carpenter
2013-11-08 10:38 ` Archit Taneja [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527CBC5B.2000906@ti.com \
    --to=archit@ti.com \
    --cc=dan.carpenter@oracle.com \
    --cc=grant.likely@linaro.org \
    --cc=hans.verkuil@cisco.com \
    --cc=k.debski@samsung.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).