From: James Hogan <james.hogan@imgtec.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] metag: off by one in setup_bootmem_node()
Date: Fri, 08 Nov 2013 11:33:37 +0000 [thread overview]
Message-ID: <527CCC11.9000709@imgtec.com> (raw)
In-Reply-To: <20131108094533.GD27977@elgon.mountain>
On 08/11/13 09:45, Dan Carpenter wrote:
> If "nid = MAX_NUMNODES" then we write beyond the end of the node_data[]
> array.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/metag/mm/numa.c b/arch/metag/mm/numa.c
> index 9ae578c..b172aa4 100644
> --- a/arch/metag/mm/numa.c
> +++ b/arch/metag/mm/numa.c
> @@ -34,7 +34,7 @@ void __init setup_bootmem_node(int nid, unsigned long start, unsigned long end)
> unsigned long pgdat_paddr;
>
> /* Don't allow bogus node assignment */
> - BUG_ON(nid > MAX_NUMNODES || nid <= 0);
> + BUG_ON(nid >= MAX_NUMNODES || nid <= 0);
>
> start_pfn = start >> PAGE_SHIFT;
> end_pfn = end >> PAGE_SHIFT;
Thanks, Applied for v3.13.
Cheers
James
prev parent reply other threads:[~2013-11-08 11:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 9:45 [patch] metag: off by one in setup_bootmem_node() Dan Carpenter
2013-11-08 11:33 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527CCC11.9000709@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).