From: Larry Finger <Larry.Finger@lwfinger.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] various space fixes
Date: Mon, 11 Nov 2013 02:22:50 +0000 [thread overview]
Message-ID: <52803F7A.8030403@lwfinger.net> (raw)
In-Reply-To: <CA+1HSerVbdKzAoGFZ6YCTi+BrH+jC3JUo3yg6em1qJ9E-rq9Wg@mail.gmail.com>
On 11/10/2013 08:01 PM, Marco Lavagnino wrote:
> Fixes various warnings from empty spaces.
>
> This is the first patch I submit, so I'm not completely sure if I'm
> doing it right. If this is correct I might start submitting more
> subtantial patches. If it is wrong, please tell me what did I do
> wrong, so I can learn.
>
> Signed-off-by: Marco S Lavagnino <marco.lavagnino@gmail.com>
Your patches are based against the wrong directory. They should use the -p1
option for patch, so that they can be applied when the home directory is the
root of the kernel tree. For example, the first two lines of each file patch
should be
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
In addition, the subject of the patch should include the driver name. In your
case, it should be
[PATCH] staging: r8188eu: Various space fixes
Larry
next prev parent reply other threads:[~2013-11-11 2:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 2:01 [PATCH] various space fixes Marco Lavagnino
2013-11-11 2:22 ` Larry Finger [this message]
2013-11-11 7:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52803F7A.8030403@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).